Skip to content

CLOUDP-329800: Remove force when calling logout #4117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 11, 2025
Merged

CLOUDP-329800: Remove force when calling logout #4117

merged 3 commits into from
Aug 11, 2025

Conversation

blva
Copy link
Collaborator

@blva blva commented Aug 11, 2025 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-329800

  • Uses the same prompt as logout to run config delete
  • Uses a similar approach to deployments setup to call logout
  • Sends profile data on context
  • Fixes panic no ProfileFromContext

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@blva blva marked this pull request as ready for review August 11, 2025 12:44
@blva blva requested a review from a team as a code owner August 11, 2025 12:44
cveticm
cveticm approved these changes Aug 11, 2025
View reviewed changes
Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
I wasn't aware of ProfileFromContext, nice to know!

@blva blva merged commit 15b6220 into SA_refactor_feature_branch Aug 11, 2025
25 checks passed
@blva blva deleted the CLOUDP-329800-prompt-update branch August 11, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cveticm cveticm cveticm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blva @cveticm