testing #1
Open
testing #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-telemetry#833) * When converting to/from Jaeger set error tag if status is not ok Signed-off-by: Bogdan Drutu <[email protected]> * Do not set error=false Signed-off-by: Bogdan Drutu <[email protected]>
This code is no longer used anywhere. It was replaced by `filterspan` package.
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
While zero IDs are considered by most formats to be an error the Collector should not drop data because of that. This follows the same pattern already adopted for the Jaeger receiver.
…ces (open-telemetry#837) Signed-off-by: Bogdan Drutu <[email protected]>
New internal data structure allows to batch together traces from different resources. This simplify batching a lot. This commit removes most of the functionality for handling many batches per node and uses only one batch with one ticker.
Signed-off-by: Bogdan Drutu <[email protected]>
Instructions at https://opentelemetry.io/docs/collector/about/ were causing an error starting otel-collector related to naming. Verified that this change resulted in a successful deployment with `kubectl apply`.
- Fix typos - Update package name
Since we don't allocate attributes slice explicitly anymore, we don't need to count attributes
I've added Zipkin data receiver and sender for testbed. Few tests were updated and two new created. **Link to tracking Issue:** [Issue-482](open-telemetry#482) **Testing:** - TestGeneratorAndBackend -> changed the test name, Jaeger and Zipkin as test cases - TraceNoBackend10kSPS -> created test scenario, possibility to add new test cases - Trace10kSPS -> added Zipkin test case
…#853) * Construct directly the AttributeMap in non-test code. Signed-off-by: Bogdan Drutu <[email protected]> * Update load_generator to construct directly the AttributeMap. Signed-off-by: Bogdan Drutu <[email protected]>
* use default values for remote sampling endpoints * use default sampling strategy (in-memory) if no file/url is provided Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Translation was replicated from existing jaeger -> OC -> internal logic.
Signed-off-by: Pavol Loffay <[email protected]>
Elapsed time measurement was set incorrectly. Timeout to compare elapsed time against is triggered with newBatchProcessor, move it below the timer start.
* Add format target to makefile Signed-off-by: Pavol Loffay <[email protected]> * Add -s Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Translation is based on existing internal->OC->jaegerproto logic.
We previously used string in the codebase to represent component type (as it is known to factories and referred to in the config). Now we have configmodels.Type alias that provides stronger compile-time type checks. This is a breaking change for components but fixing the components is easy. Resolves: open-telemetry#762
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
* Refactor SecureReceiverSettings to use TLSSetting * Address test code coverage failure * Update file to use new license format * Address few small comments
…metry#993) * Remove extra send/receive annotations with using zipkin v1 Fixes open-telemetry#960 * Update test to use assert.EqualValues
The order in which Consume* and Shutdown get handled for batch processor is inconsistent when called back to back. This results in the number of items getting passed through to be inconsistent. To unblock tests and maintain coverage, the tests only check if some data got through and the batching size is 1. Issue open-telemetry#1070 has been opened to properly fix the test and ensure the total number of items sent is accounted for after shutdown has been invoked. **Link to tracking Issue:** Fixes issue open-telemetry#1066 and open-telemetry#1069 **Testing:** Run each of the test 100 times and no test failures.
…etry#1001) * filterprocessor for filtering (dropping) incoming metrics by various properties traceprocessor for spans to come in a separate PR. * Add benchmark test and use new trace processor format * Address PR and fix build * Remove testing caching processor * Address PR & increase test coverage * Pre-allocate filtered metrics slice
…ta" and added comments (open-telemetry#1074)
Signed-off-by: Bogdan Drutu <[email protected]>
* Update processor documentation - Add filter documentation - Add data sources - Update batch documentation Also fix link in exporter documentation. * Address feedback * Switch from data source to pipeline type
* Remove unnecessary Options from regexp and strict filters * Use slice for regexp when iterating (faster than iterating over map) * Fix bug in de-dup logic for regexp (`flag.CommandLine.Name()` was used instead the filter value)
Signed-off-by: Bogdan Drutu <[email protected]>
* Hard code expected labels on obsreport tests The goal is to prevent inadvertent changes of the labels. Using hard coded values requires manual changes of the tests. * Add reason to be careful about metric name and label changes
* Enable filter processor as a default processor * Fix test
* Split out processor READMEs * Split out exporter READMEs * Split out extension READMEs * Split out receiver READMEs * Add new line at end of READMEs
* Add Grafana as an adopter Signed-off-by: Joe Elliott <[email protected]> * Grafana Labs Signed-off-by: Joe Elliott <[email protected]>
…elemetry#1006) Switch from localhost to 0.0.0.0 by default Link to tracking Issue: Addresses open-telemetry#592
…open-telemetry#1100) Since OTLP span kinds has 1-1 mapping with OpenTracing specification we don't need to keep additional "span.kind" value as was done in OC internal representation. The commit fixes the issue: open-telemetry#878
…1105) Bug description: if "http.status_code" and "error" tags are both set in incoming a jaeger span, internal status code is incorrectly set to Unknown code ignoring value from http.status_code tag. This commit fixes the described bug, so http.status_code tag always has precedence over error tag during Jaeger -> Internal data model translation.
Fixes open-telemetry#954 open-telemetry#954 is being caused from the conversion of OC -> Internal -> OC span types. OC technically allows nil times because its a pointer, but [docs state](https://github.com/census-instrumentation/opencensus-proto/blob/master/src/opencensus/proto/trace/v1/trace.proto#L125-L135) ```go // This field is semantically required. When not set on receive - // receiver should set it to the value of end_time field if it was // set. Or to the current time if neither was set. It is important to // keep end_time > start_time for consistency. // // This field is required. StartTime *timestamp.Timestamp ``` So this pr changes the zipkin receiver to set the start/end timestamps if they're not set on receive
- Rename internal metric types to match OTLP metric types. - Fix all tests and usages of metric types in the codebase. - Remove references to labelkeys from MetricDescriptor since it no longer exists in OTLP. - DID NOT use the new Temporarily concept, waiting until the proto is settled down.
…try#1115) If ResourceCheckPeriod is more than 1 second, reported resource values are not being changed during each ResourceCheckPeriod, so logging every second doens't provide much value, but makes it hard to read logs in long run running tests
Add a simple go test to ensure existence of documentation for enabled components. **Link to tracking Issue:** open-telemetry#1025
The GRPC service was already defined in a previous PR. This is still experimental.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: <Describe what has changed.
Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.>
Link to tracking Issue:
Testing: < Describe what testing was performed and which tests were added.>
Documentation: < Describe the documentation added.>