Fix: re-auth interfering with connectivity checks #1144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connections might have pipelined messages when being picked up from the pool (e.g., re-auth). When unflushed those, they will be `RESET` when returned to the pool. This results in pipelineing `LOGON`, `LOGOFF`, and `RESET` where the `RESET` will skip the queue on the server side. Depending on the timing, this will leave the connection in an undesirable state (e.g., unauthenticated). This PR circumvents this situation by acquiring an unprepared connection from the pool when performing connectivity checks. Such connections will not have any work pipelined.
MaxAake
reviewed
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections might have pipelined messages when being picked up from the pool (e.g., re-auth). When unflushed, those connections will be
RESETwhen returned to the pool. This results in pipelineingLOGON,LOGOFF, andRESETwhere theRESETwill skip the queue on the server side. Depending on the timing, this will leave the connection in an undesirable state (e.g., unauthenticated).This PR circumvents this situation by acquiring an unprepared connection from the pool when performing connectivity checks. Such connections will not have any work pipelined.