Don't close drivers & sessions in finalizer #1183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer implicitly closing drivers and sessions in
__del__()(finalizer/destructor). Make sure to call.close()on them explicitly or use them in awithstatement.A deprecation warning has been emitted in such cases before.
Relying on
__del__leads to hard to follow control flow and can result in surprising behavior as there is no guarantee when that the finalizer will be called if ever. A ResourceWarning is emitted instead.See also: https://docs.python.org/3/reference/datamodel.html#object.__del__