Support reading multiple JSON syntax blocks in a single input (#269) #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fu-turer
approved these changes
Jul 21, 2025
UrielCh
reviewed
Aug 2, 2025
| @@ -41,14 +47,6 @@ public Object parse(byte[] in) throws ParseException { | |||
| return parse(in, JSONValue.defaultReader.DEFAULT); | |||
| } | |||
|
|
|||
| // | |||
There was a problem hiding this comment.
It's important that we maintain the blank lines in this file. They aren't 'empty' code; they're there to synchronize line numbers with similar files. In this pull request, you've added six lines and removed seven, which has broken this synchronization. Please adjust your changes to restore the correct line number offset.
UrielCh
reviewed
Aug 2, 2025
| @@ -54,13 +58,4 @@ public <T> T parse(InputStream in, JsonReaderI<T> mapper) | |||
| // | |||
| return super.parse(i2, mapper); | |||
| } | |||
|
|
|||
| // | |||
There was a problem hiding this comment.
double check lines offset ans preserve some empty lines here probably should keep 5 out of 9
UrielCh
reviewed
Aug 2, 2025
| @@ -28,8 +28,6 @@ | |||
| * @see JSONParserReader | |||
| */ | |||
| abstract class JSONParserStream extends JSONParserBase { | |||
| // len | |||
There was a problem hiding this comment.
do not drop those offset empty lines.
|
please keep the original line sync across similar files. |
UrielCh
added a commit
that referenced
this pull request
Aug 2, 2025
* improve testing * fix maven-resources-plugin version to 3.3.1 * patch on github ations * patch versions * fix version * rollback versions * downgrade * add condition for github workflows * patch action * test patch action * edd exta test in action * add jacoco * patch coverage * patch coverage * Support reading multiple JSON syntax blocks in a single input (#269) (#272) Co-authored-by: QIURC <[email protected]> * change year + offset some code + fix warning * fix warnings * fix warnings * add missing jsdoc * add missing jsdoc * spotless:apply * add tests * mvn spotless:apply * add tests * mvn spotless:apply * add tests * add publishing action * update changelog --------- Co-authored-by: Caimo <[email protected]> Co-authored-by: QIURC <[email protected]>
UrielCh
added a commit
that referenced
this pull request
Aug 2, 2025
* improve testing * fix maven-resources-plugin version to 3.3.1 * patch on github ations * patch versions * fix version * rollback versions * downgrade * add condition for github workflows * patch action * test patch action * edd exta test in action * add jacoco * patch coverage * patch coverage * Support reading multiple JSON syntax blocks in a single input (#269) (#272) Co-authored-by: QIURC <[email protected]> * change year + offset some code + fix warning * fix warnings * fix warnings * add missing jsdoc * add missing jsdoc * spotless:apply * add tests * mvn spotless:apply * add tests * mvn spotless:apply * add tests * add publishing action * update changelog * patch relase script --------- Co-authored-by: Caimo <[email protected]> Co-authored-by: QIURC <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #269