Move datasource/host to pkg
#1182
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhurley
approved these changes
Aug 8, 2025
| resourceID := info.ResourceID(ctx) | ||
| resourceID, err := info.ResourceID(ctx) | ||
| if err != nil { | ||
| slog.WarnContext(ctx, "Failed to get ResourceID from host info", "error", err.Error()) |
There was a problem hiding this comment.
Suggested change
| slog.WarnContext(ctx, "Failed to get ResourceID from host info", "error", err.Error()) | |
| slog.WarnContext(ctx, "Failed to get ResourceID from host info", "error", err) |
aphralG
reviewed
Aug 11, 2025
| @@ -103,117 +105,146 @@ func NewInfo() *Info { | |||
| } | |||
| } | |||
|
|
|||
| func (i *Info) IsContainer() bool { | |||
| res, err, _ := singleflightGroup.Do(IsContainerKey, func() (interface{}, error) { | |||
There was a problem hiding this comment.
Since single flight has been removed from the functions does something need to be done where they are being called to prevent duplicate function calls?
There was a problem hiding this comment.
I think it's only called once per new resource, so I don't think there's a danger of duplicate calls, AFAIK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Moves the
internal/datasource/hosttopkgso other teams can use the logic for generating theresource id.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)