-
Notifications
You must be signed in to change notification settings - Fork 129
Open
Labels
enhancementNew feature or requestNew feature or requesthighlightRelates to features that should be promoted despite not being an epicRelates to features that should be promoted despite not being an epicrefinedRequirements are refined and the issue is ready to be implemented.Requirements are refined and the issue is ready to be implemented.size/largeEstimated to be completed within two weeksEstimated to be completed within two weeks
Milestone
Description
Is your enhancement request related to a problem? Please describe.
There are many Deployment and Service fields that can be customized, and having to expose all of them in the NginxProxy resource is tedious and unnecessary for uncommonly used fields.
What would you like to be added:
Add a way to submit custom patches to unblock users who need to set fields that are not yet exposed in the NginxProxy CRD.
Why this is needed:
Reduce blockages for fields that users need to have set.
Acceptance
- User has a method to patch deployment and service objects provisioned by NGF with Kubernetes patch JSON
- Default patch type is StrategicMerge
- The data plane configuration doc is updated to demonstrate how patches can be applied to provisioned objects.
Dev notes
- Patch should accept a Patch Type and raw JSON
- We can use marshaling and patch merging to copy the user patch on top of the deployment/service objects before provisioning.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requesthighlightRelates to features that should be promoted despite not being an epicRelates to features that should be promoted despite not being an epicrefinedRequirements are refined and the issue is ready to be implemented.Requirements are refined and the issue is ready to be implemented.size/largeEstimated to be completed within two weeksEstimated to be completed within two weeks
Type
Projects
Status
👀 In Review