Add workflow to push README to Docker Hub #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacome
force-pushed
the
chore/add-dockerhub-description
branch
from
7f1ef7c to
e4b9e8b
Compare
lucacome
requested review from
a team,
ciarams87 and
soneillf5
and removed request for
a team
soneillf5
approved these changes
May 10, 2021
soneillf5
reviewed
May 10, 2021
| - name: Modify readme for DockerHub | ||
| run: | | ||
| sed -i '1,2d' README.md | ||
| sed -i 's/(LICENSE)/(https:\/\/github.com\/nginxinc\/nginx-prometheus-exporter\/blob\/master\/LICENSE)/' README.md |
There was a problem hiding this comment.
why the extra 'sed' here ? The other PR only has onehttps://github.com/nginxinc/nginx-ingress-operator/pull/108/files
There was a problem hiding this comment.
it's the only repo where we have the LICENSE linked in the README, but mainly it was just a "test" to see what we can do if we want to customize them more.
ciarams87
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add description for https://hub.docker.com/r/nginx/nginx-prometheus-exporter