feat: provide a few convenience methods for ngx_str_t and ngx_array_t
#178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former is particularly useful when parsing the configuration to avoid creation of an intermediate reference. The latter added for sake of completeness.
There was a problem hiding this comment.
Pull Request Overview
This PR adds convenience methods to ngx_str_t and ngx_array_t types to simplify configuration parsing in nginx modules. The changes provide safer, more ergonomic interfaces for working with these core nginx data structures.
- Adds string manipulation methods (
split_at,strip_prefix,strip_suffix) tongx_str_t - Adds slice conversion methods (
as_slice,as_slice_mut) tongx_array_t - Updates example files to use the new convenience methods instead of manual pointer arithmetic
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| nginx-sys/src/string.rs | Implements string manipulation methods and adds comprehensive tests |
| nginx-sys/src/lib.rs | Implements array-to-slice conversion methods with safety documentation |
| examples/upstream.rs | Updates configuration parsing to use new array slice method |
| examples/shared_dict.rs | Replaces manual slice creation with new convenience method |
| examples/curl.rs | Simplifies array access using new slice conversion |
| examples/awssig.rs | Updates multiple configuration handlers to use new array methods |
| examples/async.rs | Replaces manual slice construction with convenience method |
xeioex
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commits.
Both changes are meant to simplify the configuration parsing.