This repository was archived by the owner on May 24, 2023. It is now read-only.
Add tls secret option #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
vepatel
reviewed
Jul 6, 2021
| @@ -147,6 +147,7 @@ spec: | |||
| | --- | --- | --- | --- | | |||
| | `enable` | `boolean` | Enable Prometheus metrics. | Yes | | |||
| | `port` | `int` | Sets the port where the Prometheus metrics are exposed. Default is 9113. Format is `1023 - 65535`. | No | | |||
| | `secret` | `string` | Sets the namespace/name of a TLS Secret Resource to use to enable TLS for the Prometheus endpoint. | No | | |||
There was a problem hiding this comment.
think need to add arg above line 76 too
There was a problem hiding this comment.
I've updated the example if that's what you mean? I don't see anywhere else to add it
lucacome
previously requested changes
Jul 6, 2021
| @@ -197,6 +197,13 @@ spec: | |||
| minimum: 1023 | |||
| nullable: true | |||
| type: integer | |||
| secret: | |||
| description: A Secret with a TLS certificate and key for TLS termination | |||
There was a problem hiding this comment.
This description (and the one in bundle) doesn't match the comment in types. I think you need to run make bundle again.
There was a problem hiding this comment.
Ah I didn't realise it was generated. I ran make bundle and got the following error:
make bundle
/Users/soneill/go/src/github.com/nginxinc/nginx-ingress-operator/bin/controller-gen "crd:trivialVersions=true,preserveUnknownFields=false" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
operator-sdk generate kustomize manifests -q
FATA[0000] failed to read config: error unmarshalling project configuration: error unmarshaling JSON: while decoding JSON: json: cannot unmarshal array into Go struct field Config.layout of type string
make: *** [bundle] Error 1
I've update this PR anyway with he generated changes.
There was a problem hiding this comment.
The files in bundle are auto-generated too.
vepatel
approved these changes
Jul 7, 2021
ciarams87
approved these changes
Jul 7, 2021
soneillf5
force-pushed
the
feature/prometheus-https
branch
from
f22ac6b to
574a2e6
Compare
soneillf5
dismissed
lucacome’s stale review
Approved by other reviewers, merge is blocked with timezone difference
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.