Skip to content
This repository was archived by the owner on May 24, 2023. It is now read-only.

🐞 fix(controller):update deployment or daemonset error #158

Merged
merged 3 commits into from
Sep 23, 2021
Merged

🐞 fix(controller):update deployment or daemonset error #158

merged 3 commits into from
Sep 23, 2021

Conversation

sunlintong
Copy link
Contributor

Proposed changes

This works well in 0.2.0, but now it can't update deployment or daemonset, fixed.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@sunlintong
Copy link
Contributor Author

@ciarams87 @vepatel

@sunlintong
Copy link
Contributor Author

@lucacome

@ciarams87 ciarams87 merged commit 03c6609 into nginxinc:master Sep 23, 2021
@ciarams87 ciarams87 added the bug An issue reporting a potential bug label Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lucacome lucacome Awaiting requested review from lucacome

@soneillf5 soneillf5 Awaiting requested review from soneillf5

2 more reviewers

@pleshakov pleshakov pleshakov approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunlintong @pleshakov @ciarams87