This repository was archived by the owner on May 24, 2023. It is now read-only.
Fix leader election for IC pods #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The operator now configures the leader-election-lock-name cli argument of the IC with the value based on the name of the NginxIngressController resource. This allows delpoying multiple ICs in the same namespace. - The documentation and type of the spec.EnableLeaderElection is updated: it is now a pointer with the default value 'true'. This matches the default value of the corresponding IC cli argument. The previous behavior was also incorrect - the operator would always enable the leader election, no matter the value of spec.EnableLeaderElection.
pleshakov
added
bug
github-actions
bot
added
the
documentation
ciarams87
approved these changes
Apr 1, 2021
soneillf5
approved these changes
Apr 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
argument of the IC with the value based on the name of the
NginxIngressController resource. This allows deploying multiple
ICs in the same namespace.
updated: it is now a pointer with the default value 'true'. This
matches the default value of the corresponding IC cli argument.
The previous behavior was also incorrect - the operator would always
enable the leader election, no matter the value of
spec.EnableLeaderElection.
Fixes #87