Bug with `set()` functions

[Seb33300]

Hello,

On a Laravel project, I am using deployer where a set() function is defined to setup the global configurations.

Since PHP-Parser version 5.4.0, it seems like something wrong happened with that set() function, breaking my Pint (PHP-CS-Fixer for Laravel) pipelines in my project.

I created a reproducer in the Pint project here: laravel/pint#353

This seems to be related somehow to latest changes in PropertyHook where I can see some set hardcoded?
See: 6478c5a#diff-7b34ed55e32983d7ed56a09fc70ba016f0b84cf024c8062b8dcb2682157edca4

[Seb33300]

Can also be related to phpstan/phpstan-src#3746
@ondrejmirtes ?

[Seb33300]

Only PHP-Parser seems to have been updated when the issue occured for the first time.
So the issue is more likely to come from PHP-Parser.

This

<?php

if (true) {
    set();
}

Results into this somehow:

<?php

if (true) {
    {set();}
}

[nikic]

To confirm, you're seeing this issue with PHP-Parser 5.4.0, but not if you downgrade to 5.3.1?

The changes to PropertyHook should not be related to this, as your code is a plain function call, not a property hook.

[Seb33300]

I am facing this bug with Pint 1.19.0, but not with Pint 1.18.3.

PHP-Parser was upgraded from v5.3.1 to v5.4.0. (but this was not the only one lib upgraded).
I just found some mentions to set in your changelog so I though it may be related.

Since I created that issue, someone also created a very similar issue happening with get() function.

[ondrejmirtes]

This is a low-level library. Please debug this issue further so we can see where the bug is. It might not be in PHP-Parser.

[Seb33300]

Hi @ondrejmirtes,
I understand this is a low level library, but I assume Pint or PHP-CS-Fixed is somehow relying on it.
The issue occurs only with PHP 8.4, not on PHP 8.3.
And only with get() and set() functions.

This can't be a coincidence with changes mentioned in my previous message or your PR in PHPStan: phpstan/phpstan-src#3746

[Seb33300]

After more investigation, it looks like this bugs is in PHP-CS-Fixer