Skip to content

FIX: adhoc colormap can lead to error because float should be int #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2020
Merged

FIX: adhoc colormap can lead to error because float should be int #288

merged 1 commit into from
Feb 21, 2020

Conversation

kingjr
Copy link
Contributor

@kingjr kingjr commented Feb 20, 2020

No description provided.

larsoner
larsoner approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures are unrelated and fixed in #287, let's wait for that to be merged, restart the CIs here, then merge this

@codecov
Copy link

codecov bot commented Feb 21, 2020 •
edited
Loading

Codecov Report

Merging #288 into master will increase coverage by 1.89%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
+ Coverage    74.5%   76.39%   +1.89%     
==========================================
  Files           7        7              
  Lines        2577     2991     +414     
  Branches      513      670     +157     
==========================================
+ Hits         1920     2285     +365     
- Misses        480      522      +42     
- Partials      177      184       +7

@larsoner larsoner merged commit 6962fe9 into nipy:master Feb 21, 2020
@larsoner
Copy link
Contributor

Thanks @kingjr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsoner larsoner larsoner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingjr @larsoner