Skip to content

CI: Build docker images with Python 3.8 #3287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

effigies
Copy link
Member

@effigies effigies commented Jan 5, 2021

Circle tests are failing because h5py no longer builds wheels for Python 3.6, and our docker images are not equipped to build the wheels. Python 3.6 is on its way out, so upgrading to Python 3.8.

Or should I target 3.9?

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #3287 (ed6ad57) into master (47fe00b) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3287      +/-   ##
==========================================
+ Coverage   64.70%   64.78%   +0.08%     
==========================================
  Files         302      302              
  Lines       39869    39976     +107     
  Branches     5288     5289       +1     
==========================================
+ Hits        25796    25898     +102     
- Misses      12984    12987       +3     
- Partials     1089     1091       +2     
Flag Coverage Δ
unittests 64.78% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/pipeline/plugins/multiproc.py 76.36% <0.00%> (-2.43%) ⬇️
nipype/pipeline/plugins/linear.py 76.19% <0.00%> (-2.39%) ⬇️
nipype/pipeline/plugins/legacymultiproc.py 63.23% <0.00%> (-2.12%) ⬇️
nipype/pipeline/engine/utils.py 74.22% <0.00%> (-0.26%) ⬇️
nipype/utils/filemanip.py 71.46% <0.00%> (ø)
nipype/interfaces/minc/minc.py 85.18% <0.00%> (+0.01%) ⬆️
nipype/interfaces/fsl/preprocess.py 71.44% <0.00%> (+0.03%) ⬆️
nipype/interfaces/ants/registration.py 73.09% <0.00%> (+0.05%) ⬆️
nipype/interfaces/base/specs.py 89.28% <0.00%> (+0.05%) ⬆️
nipype/interfaces/base/traits_extension.py 88.29% <0.00%> (+0.06%) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47fe00b...ed6ad57. Read the comment docs.

@effigies
Copy link
Member Author

In the absence of response, I'm just going to do it.

@effigies effigies merged commit 28d76cf into nipy:master Apr 30, 2021
@effigies effigies deleted the mnt/docker_python_3_8 branch April 30, 2021 21:53
@effigies effigies added this to the 1.6.1 milestone May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant