Skip to content

test: Pin openai test dependency to fix CI build #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

timfish
Copy link
Contributor

@timfish timfish commented Feb 25, 2025

Because we don't commit the lock file, changing test dependencies can break our tests!

@jsumners-nr
Copy link
Contributor

Because we don't commit the lock file, changing test dependencies can break our tests!

I think this is, or should be, intentional. If a new version of a "supported" library breaks things, then this library is broken and needs to be fixed. I don't think pinning is the right solution.

@timfish
Copy link
Contributor Author

timfish commented Feb 25, 2025

I think the change in openai that causes these new test failures is related to one of the other bugs which we can't fix. I need to double check this though.

@jsumners-nr
Copy link
Contributor

If that is the case, then we have just hit a version range of support. Add another nail to the ⚰️.

Copy link
Contributor

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with merging this in to unblock CI, since it seems we have some PRs in the queue to try to get merged!

let's open a GH issue so that we atleast keep the openai stuff in mind.

@AbhiPrasad
Copy link
Contributor

Looks like svelte is also having issues?

@mohd-akram
Copy link
Contributor

#181 addresses both svelte and openai. Updated it with a test case and a description of the issue and the fix.
#182 fixes globals and mime-db

With both PRs, importing all packages in the integration CI should succeed.

@timfish
Copy link
Contributor Author

timfish commented Feb 28, 2025

Closing in favour of #181

@timfish timfish closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants