Skip to content

build: do not set -mminimal-toc with clang #59484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: do not set -mminimal-toc with clang #59484

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

This is a gcc-only option, do not pass to clang.

Refs: nodejs/build#4091
Refs: nodejs/build#4123 (comment)

@richardlau
build: do not set -mminimal-toc with clang
dfacded 
This is a gcc-only option, do not pass to clang.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Aug 15, 2025
@richardlau richardlau added the ppc Issues and PRs related to the Power architecture. label Aug 15, 2025
@richardlau richardlau mentioned this pull request Aug 15, 2025
Draft
35 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 15, 2025 •
edited by richardlau
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/68656/
with clang: https://ci.nodejs.org/job/richardlau-node-test-commit-plinux/13/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 15, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68664/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. ppc Issues and PRs related to the Power architecture.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@richardlau @nodejs-github-bot @lpinca @targos @RafaelGSS @RaisinTen