Skip to content

fix: RSS button navigate to 404 page if not with en locale #8073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: RSS button navigate to 404 page if not with en locale #8073

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9711b54
fix: rss button navigate to 404 page if not with en locale
kylemocode Aug 13, 2025
4949240
fix: applied fix on link on generation
kylemocode Aug 13, 2025
edba725
fix: rollback to link based solution
kylemocode Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/site/components/Blog/BlogHeader/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ const BlogHeader: FC<BlogHeaderProps> = ({ category }) => {
{t('layouts.blog.title')}
<Link
href={`/feed/${currentFile}`}
{...{ locale: 'en' }} // RSS feeds only exist in English
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{...{ locale: 'en' }} // RSS feeds only exist in English
locale='en' // RSS feeds only exist in English

Copy link
Author

@kylemocode kylemocode Aug 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avivkeller
I used object spread here to pass locale because our custom Link component’s prop types are based on HTMLAnchorElement and don’t include locale, thus will cause type error. This approach avoids a larger refactor while keeping the behavior consistent with how the locale prop would be passed in a properly typed Next.js Link. It also ensures we don’t introduce unnecessary complexity just to satisfy type checking for a value that is already fixed (en).

截圖 2025-08-15 晚上9 06 08

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather perform the larger change than have a hacky solution.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix it in a PR right now

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also do that change in my day time tomorrow.
I will see if there is an updated one tomorrow, or else I can help the change.
Thanks for the feedback @avivkeller

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #8081

aria-label={t('components.blog.blogHeader.rssLink')}
>
<RssIcon />
Expand Down