Hid feature report #18150
Closed
Hid feature report #18150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 21, 2025 16:15
identifier, a 128 bit identifier unique to NVDA is now sent as a HID feature report, enabling a Braille display to identify that the connection is coming from NVDA.
identifier, a 128 bit identifier unique to NVDA is now sent as a HID feature report, enabling a Braille display to identify that the connection is coming from NVDA.
…tzmacher/nvda into hid_feature_report
seanbudd
reviewed
May 26, 2025
seanbudd
added
the
conceptApproved
seanbudd
reviewed
May 30, 2025
source/hwIo/hid.py
Outdated
| class HidFeatureReport(HidReport): | ||
| _reportType = hidpi.HIDP_REPORT_TYPE.FEATURE | ||
|
|
||
| def __init__(self, device, reportID=0): |
source/hwIo/hid.py
Outdated
| super().__init__(device) | ||
|
|
||
| @property | ||
| def data(self): |
source/hwIo/hid.py
Outdated
| def data(self): | ||
| return self._reportBuf.raw | ||
|
|
||
| def setUsageValueArray(self, usagePage, linkCollection, usage, data): |
…f section about screen reader identifier Co-authored-by: Sean Budd <[email protected]>
|
@FelixGruetzmacher - is this ready for re-review? |
|
Closing as abandoned |
SaschaCowley
added
the
Abandoned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Does not apply
Summary of the issue:
A HID Braille device can expect a screen reader identifier that signifies to the device what screen reader has initiated communication. Currently, NVDA ignores this.
Description of user facing changes
No immediate changes of behavior.
Description of development approach
The HID Braille driver queries the report descriptor for the presence of the screen reader identifier usage in the feature report. If the usage is found, then as part of initialization, a UUID signifying NVDA (newly generated from a source of random numbers) is sent as the screen reader identifier.
Testing strategy:
Tested against Help Tech HID devices with and without this usage in their report descriptors.
Known issues with pull request:
None.
Code Review Checklist:
@coderabbitai summary