Fix root certificate issues for add-on store #18354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
If a device doesn't trust NV Access's TLS certificate, fetches to the add-on store fails.
When performing an update check, we update windows root certificates if our certificate is invalid or out of date.
Description of user facing changes:
Users without a trusted NV Access TLS certificate installed already should be able to access the add-on store
Description of developer facing changes:
Code related to updating root certificates is deprecated as it is not intended for the public
Description of development approach:
Made the code to update certificates more generic
Testing strategy:
requests.get
in_fetchUrlAndUpdateRootCertificates
to send our bad certificate chain. e.g.result = requests.get(url, timeout=_FETCH_TIMEOUT_S, verify=r"C:\Users\sean\Downloads\nvaccess-org-chain.pem")
Known issues with pull request:
none
Code Review Checklist:
@coderabbitai summary