Skip to content

Observable footer #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Observable footer #1693

merged 2 commits into from
Jun 14, 2023

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Jun 14, 2023

ported from d3/d3@1582f4a

changes:

  • copyright: Observable, Inc.
  • releases URL
  • license URL

footer

ported from d3/d3@1582f4a

changes:
- copyright: Observable, Inc.
- releases URL
- license URL
@Fil Fil requested a review from mbostock June 14, 2023 16:05
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I wonder if we should link to D3 in the footer, too?

@Fil Fil enabled auto-merge (squash) June 14, 2023 17:18
@Fil
Copy link
Contributor Author

Fil commented Jun 14, 2023

I think it's fine with the link in the header, but we can revisit

@Fil Fil merged commit 2d4a2f6 into main Jun 14, 2023
@Fil Fil deleted the fil/footer branch June 14, 2023 17:20
Fil added a commit that referenced this pull request Aug 21, 2023
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants