ignore null transform #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
reviewed
Jul 31, 2021
src/plot.js
Outdated
| @@ -35,7 +35,7 @@ export function plot(options = {}) { | |||
| if (scale !== undefined) { | |||
| const scaled = scaleChannels.get(scale); | |||
| const {percent, transform = percent ? x => x * 100 : undefined} = options[scale] || {}; | |||
| if (transform !== undefined) channel.value = Array.from(channel.value, transform); | |||
| if (typeof transform === "function") channel.value = Array.from(channel.value, transform); | |||
There was a problem hiding this comment.
I didn’t mean we should silently ignore a invalid argument, like if you pass a transform object instead of a function. Instead I meant we should consider null and undefined to be equivalent here. I’ll make the change and merge.
mbostock
force-pushed
the
fil/null-scale-transform-357
branch
from
71e22e1 to
2b5c819
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #357