Skip to content

[IMP] sms_marketing: add Twilio documentation #13909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

RicGR98
Copy link
Contributor

@RicGR98 RicGR98 commented Jul 2, 2025

task-4658352

@robodoo
Copy link
Collaborator

robodoo commented Jul 2, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team July 2, 2025 11:01
@RicGR98 RicGR98 force-pushed the 17.0-twilio-rigr branch from 2dd7760 to cfc6222 Compare July 2, 2025 11:07
@RicGR98
Copy link
Contributor Author

RicGR98 commented Jul 2, 2025

Hello @odoo/sms-marketing-doc-review
Could we have a speedy review on this one such that when the feature is released (waiting for a final review, and it's an urgent task), the doc is ready too ? :)
Thanks :)

@RicGR98
Copy link
Contributor Author

RicGR98 commented Jul 14, 2025

@odoo/sms-marketing-doc-review up :)

Copy link
Contributor Author

@RicGR98 RicGR98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps @odoo/doc-review ? :)

@Feyensv
Copy link
Collaborator

Feyensv commented Jul 24, 2025

@StraubCreative Could you (or someone from your team) do the review here please ?

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just caught some repeating formatting items. I will push up the changes and merge momentarily.

Thank you for the contribution @RicGR98 and for the nudge @Feyensv

Comment on lines 51 to 52
In some countries with stricter regulations, the out-of-the-box solution proposed by Odoo
may not work. In this case, you can use our Twilio integration to send SMS worldwide.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

early line break

Suggested change
In some countries with stricter regulations, the out-of-the-box solution proposed by Odoo
may not work. In this case, you can use our Twilio integration to send SMS worldwide.
In some countries with stricter regulations, the out-of-the-box solution proposed by Odoo may
not work. In this case, you can use our Twilio integration to send SMS worldwide.


#. Go to `Twilio <https://www.twilio.com>`_
#. Sign up and create a Twilio account
#. Within your Twilio account, you can create multiple accounts (e.g. one for testing, one for each sub-company, etc.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100th-character limit

Suggested change
#. Within your Twilio account, you can create multiple accounts (e.g. one for testing, one for each sub-company, etc.)
#. Within your Twilio account, you can create multiple accounts (e.g. one for testing, one for each
sub-company, etc.)

Setup your Twilio account
=========================

By creating a Twilio account, you will be able to create a virtual phone number from
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 54 to 55
#. In Odoo, go to :menuselection:`Settings --> General Settings --> Contacts --> Send SMS`,
select :guilabel:`Twilio` in the list of options, and save your change.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 8 to 9
Twilio is a third-party provider that enables you to send SMS messages to your clients.
Odoo provides an easy way to use this service within your Odoo apps.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

early line break

Suggested change
Twilio is a third-party provider that enables you to send SMS messages to your clients.
Odoo provides an easy way to use this service within your Odoo apps.
Twilio is a third-party provider that enables you to send SMS messages to your clients. Odoo
provides an easy way to use this service within your Odoo apps.

@StraubCreative
Copy link
Contributor

CRs addressed + rebase on 481e54d
Checks pass ✅
.....
@robodoo r+

@Feyensv
Copy link
Collaborator

Feyensv commented Jul 25, 2025

Well, the feature isn't merged so it's kinda strange to merge the doc first ...
I suppose Ricardo only wanted a review (and the delegate to merge it when the base PR was merged) 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants