-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[ADD] timesheets: billing rate leaderboad #13921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8d75a8d
to
b01afc2
Compare
4734f22
to
3e84da4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work @zulu-odoo! I added a few comments and suggestions 🙂. Also:
- Could you please change the PR title and commit message to change [NEW] into [ADD]?
- Don't forget the app name in your anchor names (timesheets/billing_rates/xxx)
- Could we use this opportunity (i.e., PR) to get rid of the empty "Overview" toc tree?

Thank you!
content/applications/services/timesheets/overview/billing_rates.rst
Outdated
Show resolved
Hide resolved
content/applications/services/timesheets/overview/billing_rates.rst
Outdated
Show resolved
Hide resolved
content/applications/services/timesheets/overview/billing_rates.rst
Outdated
Show resolved
Hide resolved
A new item, :guilabel:`Billing Time Targets` is then added in the :guilabel:`Configuration` menu. To | ||
set up the targets, click :guilabel:`Billing Time Targets`, then encode the :guilabel:`Monthly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We don't usually mention that menu items are "added" and instead focus on actionable steps (e.g., To configure xxx, go to yy --> zz --> aa, enable blabla, etc.)
- This is only true from 18.2; in 18.0, you need to click the internal link under the setting
A new item, :guilabel:`Billing Time Targets` is then added in the :guilabel:`Configuration` menu. To | |
set up the targets, click :guilabel:`Billing Time Targets`, then encode the :guilabel:`Monthly | |
To set up the targets, click :guilabel:`Set employee billing time targets`, then encode the :guilabel:`Monthly |
in 18.2, I'd add the menu as an alternative:
A new item, :guilabel:`Billing Time Targets` is then added in the :guilabel:`Configuration` menu. To | |
set up the targets, click :guilabel:`Billing Time Targets`, then encode the :guilabel:`Monthly | |
To set up the targets, click :guilabel:`Set employee billing time targets` or go to :menuselection:`Timesheets --> Configuration --> Billing Time Targets`, then encode the :guilabel:`Monthly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted for 18.2! Thank you for catching it <3
content/applications/services/timesheets/overview/billing_rates.rst
Outdated
Show resolved
Hide resolved
content/applications/services/timesheets/overview/billing_rates.rst
Outdated
Show resolved
Hide resolved
content/applications/services/timesheets/overview/billing_rates.rst
Outdated
Show resolved
Hide resolved
content/applications/services/timesheets/overview/billing_rates.rst
Outdated
Show resolved
Hide resolved
content/applications/services/timesheets/overview/billing_rates.rst
Outdated
Show resolved
Hide resolved
To create or edit existing tips, navigate to :menuselection:`Timesheets --> Configuration --> Tips`. | ||
To create a new tip, click :guilabel:`New`, and to edit the existing one, double-click on its text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like maybe we could group these two sentences (it would also avoid repetitions):
To create or edit existing tips, navigate to :menuselection:`Timesheets --> Configuration --> Tips`. | |
To create a new tip, click :guilabel:`New`, and to edit the existing one, double-click on its text. | |
To create or edit existing tips, navigate to :menuselection:`Timesheets --> Configuration --> Tips`, then click :guilabel:`New` or double-click a tip's text. |
39a8f9f
to
7a89034
Compare
7a89034
to
0d055dc
Compare
Hi @auva-odoo , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @zulu-odoo! I just have two more comments 🙂
.. note:: | ||
Once the :guilabel:`Billing Rate Indicators` have been enabled, you can also navigate to the | ||
**Employees** app, access the employee form that you wish to edit, and navigate to the | ||
:guilabel:`Settings` tab. Scroll down to :guilabel:`Application settings`, then encode the | ||
:guilabel:`Monthly Billing Time Target`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would edit this note so we don't repeat the exact same steps as mentionned above (i.e., only keep the part about going to the Employees app):
.. note:: | |
Once the :guilabel:`Billing Rate Indicators` have been enabled, you can also navigate to the | |
**Employees** app, access the employee form that you wish to edit, and navigate to the | |
:guilabel:`Settings` tab. Scroll down to :guilabel:`Application settings`, then encode the | |
:guilabel:`Monthly Billing Time Target`. | |
.. note:: | |
Once the :guilabel:`Billing Rate Indicators` have been enabled, you can also set the employees' :guilabel:`Monthly Billing Time Target` directly from the **Employees** app. |
0d055dc
to
3bceee8
Compare
@auva-odoo Done! Thank you for an amazing review, as always! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @zulu-odoo !
@robodoo r+
task-id: 4882126