Skip to content

[ADD] timesheets: billing rate leaderboad #13921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zulu-odoo
Copy link
Contributor

task-id: 4882126

@robodoo
Copy link
Collaborator

robodoo commented Jul 3, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team July 3, 2025 08:22
@zulu-odoo zulu-odoo force-pushed the 18.0-timesheets-rates-zulu branch from 8d75a8d to b01afc2 Compare July 3, 2025 08:41
@zulu-odoo zulu-odoo requested review from a team and removed request for a team July 3, 2025 08:41
@zulu-odoo zulu-odoo force-pushed the 18.0-timesheets-rates-zulu branch 2 times, most recently from 4734f22 to 3e84da4 Compare July 4, 2025 12:39
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work @zulu-odoo! I added a few comments and suggestions 🙂. Also:

  • Could you please change the PR title and commit message to change [NEW] into [ADD]?
  • Don't forget the app name in your anchor names (timesheets/billing_rates/xxx)
  • Could we use this opportunity (i.e., PR) to get rid of the empty "Overview" toc tree?
image

Thank you!

Comment on lines 23 to 24
A new item, :guilabel:`Billing Time Targets` is then added in the :guilabel:`Configuration` menu. To
set up the targets, click :guilabel:`Billing Time Targets`, then encode the :guilabel:`Monthly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We don't usually mention that menu items are "added" and instead focus on actionable steps (e.g., To configure xxx, go to yy --> zz --> aa, enable blabla, etc.)
  • This is only true from 18.2; in 18.0, you need to click the internal link under the setting
Suggested change
A new item, :guilabel:`Billing Time Targets` is then added in the :guilabel:`Configuration` menu. To
set up the targets, click :guilabel:`Billing Time Targets`, then encode the :guilabel:`Monthly
To set up the targets, click :guilabel:`Set employee billing time targets`, then encode the :guilabel:`Monthly

in 18.2, I'd add the menu as an alternative:

Suggested change
A new item, :guilabel:`Billing Time Targets` is then added in the :guilabel:`Configuration` menu. To
set up the targets, click :guilabel:`Billing Time Targets`, then encode the :guilabel:`Monthly
To set up the targets, click :guilabel:`Set employee billing time targets` or go to :menuselection:`Timesheets --> Configuration --> Billing Time Targets`, then encode the :guilabel:`Monthly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted for 18.2! Thank you for catching it <3

Comment on lines 90 to 91
To create or edit existing tips, navigate to :menuselection:`Timesheets --> Configuration --> Tips`.
To create a new tip, click :guilabel:`New`, and to edit the existing one, double-click on its text.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like maybe we could group these two sentences (it would also avoid repetitions):

Suggested change
To create or edit existing tips, navigate to :menuselection:`Timesheets --> Configuration --> Tips`.
To create a new tip, click :guilabel:`New`, and to edit the existing one, double-click on its text.
To create or edit existing tips, navigate to :menuselection:`Timesheets --> Configuration --> Tips`, then click :guilabel:`New` or double-click a tip's text.

@zulu-odoo zulu-odoo force-pushed the 18.0-timesheets-rates-zulu branch 2 times, most recently from 39a8f9f to 7a89034 Compare July 18, 2025 12:40
@zulu-odoo zulu-odoo changed the title [NEW] timesheets: billing rate leaderboad [ADD] timesheets: billing rate leaderboad Jul 18, 2025
@zulu-odoo zulu-odoo force-pushed the 18.0-timesheets-rates-zulu branch from 7a89034 to 0d055dc Compare July 18, 2025 13:02
@zulu-odoo
Copy link
Contributor Author

Hi @auva-odoo ,
Here's the updated version. Let me know if you'd like to discuss anything <3

@zulu-odoo zulu-odoo requested a review from auva-odoo July 18, 2025 14:02
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @zulu-odoo! I just have two more comments 🙂

Comment on lines 27 to 31
.. note::
Once the :guilabel:`Billing Rate Indicators` have been enabled, you can also navigate to the
**Employees** app, access the employee form that you wish to edit, and navigate to the
:guilabel:`Settings` tab. Scroll down to :guilabel:`Application settings`, then encode the
:guilabel:`Monthly Billing Time Target`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would edit this note so we don't repeat the exact same steps as mentionned above (i.e., only keep the part about going to the Employees app):

Suggested change
.. note::
Once the :guilabel:`Billing Rate Indicators` have been enabled, you can also navigate to the
**Employees** app, access the employee form that you wish to edit, and navigate to the
:guilabel:`Settings` tab. Scroll down to :guilabel:`Application settings`, then encode the
:guilabel:`Monthly Billing Time Target`.
.. note::
Once the :guilabel:`Billing Rate Indicators` have been enabled, you can also set the employees' :guilabel:`Monthly Billing Time Target` directly from the **Employees** app.

@zulu-odoo zulu-odoo force-pushed the 18.0-timesheets-rates-zulu branch from 0d055dc to 3bceee8 Compare July 23, 2025 11:28
@zulu-odoo zulu-odoo requested a review from auva-odoo July 23, 2025 11:50
@zulu-odoo
Copy link
Contributor Author

@auva-odoo Done! Thank you for an amazing review, as always!

Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zulu-odoo !

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants