-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[IMP] developer/reference/backend: dynamic dates #14105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
32f57c0
to
471cfa2
Compare
LGTM |
@AntoineVDV Could you review and r+? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I let you adapt what you want from my suggestions below, and r+ yourself because this branch is decoupled from the odoo/odoo one, and it would be better to merge the latter before the related documentation.
@robodoo delegate+
:class:`~odoo.fields.One2many`, or :class:`~odoo.fields.Many2many`) | ||
satisfies the provided domain ``value``. | ||
``any!`` (and ``not any!``) | ||
like ``any``, but bypasses access checks. | ||
|
||
* ``value`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, you could move the explanation of dynamic values after this point here, before the example
of domains usage.
Basically, what you introduce is a specific type of value, so it would make sense to show it here, and add a example to the existing examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Search domains" is already a level-3 heading, so is the "Dynamic time values". I thought of moving it there, but that's nested too deep and then I would anther header for examples and the continuation of the description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it needed a dedicated heading TBH, but not worth blocking the merge, the whole ORM page should be rewritten anyway.
Updating with multiple recently added features. Mainly grouping functions and changes in domains.
Simplify the list of operators and add `any!`.
Examples of how to specify dynamic dates in domains.
471cfa2
to
1fd65c3
Compare
Thank you. |
@robodoo rebase-ff r+ |
Merge method set to rebase and fast-forward. |
Updating with multiple recently added features. Mainly grouping functions and changes in domains. Part-of: #14105 Signed-off-by: Krzysztof Magusiak (krma) <[email protected]>
Simplify the list of operators and add `any!`. Part-of: #14105 Signed-off-by: Krzysztof Magusiak (krma) <[email protected]>
Examples of how to specify dynamic dates in domains. closes #14105 Signed-off-by: Krzysztof Magusiak (krma) <[email protected]>
No description provided.