Skip to content

[IMP] developer/reference/backend: dynamic dates #14105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

kmagusiak
Copy link
Contributor

No description provided.

@robodoo
Copy link
Collaborator

robodoo commented Jul 22, 2025

Pull request status dashboard

@kmagusiak kmagusiak force-pushed the master-domain-dynamic-dates-doc-krma branch from 32f57c0 to 471cfa2 Compare July 22, 2025 12:07
@kmagusiak kmagusiak requested review from rco-odoo and ryv-odoo July 22, 2025 12:07
@kmagusiak kmagusiak marked this pull request as ready for review July 22, 2025 12:07
@C3POdoo C3POdoo requested a review from a team July 22, 2025 12:10
@HydrionBurst
Copy link
Contributor

LGTM

@kmagusiak
Copy link
Contributor Author

@AntoineVDV Could you review and r+?

Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let you adapt what you want from my suggestions below, and r+ yourself because this branch is decoupled from the odoo/odoo one, and it would be better to merge the latter before the related documentation.

@robodoo delegate+

:class:`~odoo.fields.One2many`, or :class:`~odoo.fields.Many2many`)
satisfies the provided domain ``value``.
``any!`` (and ``not any!``)
like ``any``, but bypasses access checks.

* ``value``
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, you could move the explanation of dynamic values after this point here, before the example of domains usage.
Basically, what you introduce is a specific type of value, so it would make sense to show it here, and add a example to the existing examples.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Search domains" is already a level-3 heading, so is the "Dynamic time values". I thought of moving it there, but that's nested too deep and then I would anther header for examples and the continuation of the description.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it needed a dedicated heading TBH, but not worth blocking the merge, the whole ORM page should be rewritten anyway.

Updating with multiple recently added features.
Mainly grouping functions and changes in domains.
Simplify the list of operators and add `any!`.
Examples of how to specify dynamic dates in domains.
@kmagusiak kmagusiak force-pushed the master-domain-dynamic-dates-doc-krma branch from 471cfa2 to 1fd65c3 Compare July 29, 2025 15:11
@kmagusiak
Copy link
Contributor Author

I let you adapt what you want from my suggestions below, and r+ yourself because this branch is decoupled from the odoo/odoo one, and it would be better to merge the latter before the related documentation.

@robodoo delegate+

Thank you.
The referenced branch is already merged. The opened branch is the migration to use it throughout Odoo (should be merged soon).

@kmagusiak
Copy link
Contributor Author

@robodoo rebase-ff r+

@robodoo
Copy link
Collaborator

robodoo commented Jul 29, 2025

Merge method set to rebase and fast-forward.

robodoo pushed a commit that referenced this pull request Jul 29, 2025
Updating with multiple recently added features.
Mainly grouping functions and changes in domains.

Part-of: #14105
Signed-off-by: Krzysztof Magusiak (krma) <[email protected]>
robodoo pushed a commit that referenced this pull request Jul 29, 2025
Simplify the list of operators and add `any!`.

Part-of: #14105
Signed-off-by: Krzysztof Magusiak (krma) <[email protected]>
robodoo pushed a commit that referenced this pull request Jul 29, 2025
Examples of how to specify dynamic dates in domains.

closes #14105

Signed-off-by: Krzysztof Magusiak (krma) <[email protected]>
@robodoo robodoo closed this Jul 29, 2025
@robodoo robodoo added the 18.5 label Jul 29, 2025
@kmagusiak kmagusiak deleted the master-domain-dynamic-dates-doc-krma branch July 30, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants