[ADD] util/update_table_from_dict #297
Open
+142
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Usage example: https://github.com/odoo/upgrade/pull/8079 |
|
upgradeci retry with always only base |
Pirols
force-pushed
the
master-add_update_table_from_dict-pied
branch
5 times, most recently
from
1e5c9a3 to
31ecb56
Compare
Pirols
force-pushed
the
master-add_update_table_from_dict-pied
branch
2 times, most recently
from
3dbdbe7 to
e3ab180
Compare
A recurrent challenge in writing upgrade scripts is that of updating values in a
table based on some form of already available mapping from the id (or another
identifier) to the new value, this is often addressed with an iterative solution
in the form:
```python
for key, value in mapping.items():
cr.execute(
"""
UPDATE table
SET col = %s
WHERE key_col = %s
""",
[value, key],
)
```
or in a more efficient (only issuing a single query) but hacky way:
```python
cr.execute(
"""
UPDATE table
SET col = (%s::jsonb)->>(key_col::text)
WHERE key_col = ANY(%s)
""",
[json.dumps(mapping), list(mapping)],
)
```
With the former being ineffective for big mappings and the latter often
requiring some comments at review time to get it right.
This commit introduces a util meant to make it easier to efficiently perform
such updates.
Pirols
force-pushed
the
master-add_update_table_from_dict-pied
branch
from
e3ab180 to
876a5d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recurrent challenge in writing upgrade scripts is that of updating values in a table based on some form of already available mapping from the id (or another identifier) to the new value, this is often addressed with an iterative solution in the form:
or in a more efficient (only issuing a single query) but hacky way:
With the former being ineffective for big mappings and the latter often requiring some comments at review time to get it right. This commit introduces a util meant to make it easier to efficiently perform such updates.