Closed
Description
Component(s)
extension/jaegerremotesampling
What happened?
Description
Updating the dependency from 1.41.0 to 1.42.0 causes the following error in the test because of the change in using api_v2.SamplingStrategyResponse from sampling.SamplingStrategyResponse:
--- FAIL: TestEndpointsAreWired (0.01s)
--- FAIL: TestEndpointsAreWired/new (0.00s)
http_test.go:86:
Error Trace: /Users/alex.boten/workspace/opentelemetry-collector-contrib/extension/jaegerremotesampling/internal/http_test.go:86
Error: Not equal:
expected: "{\"strategyType\":\"PROBABILISTIC\"}"
actual : "{}"
Diff:
--- Expected
+++ Actual
@@ -1 +1 @@
-{"strategyType":"PROBABILISTIC"}
+{}
Test: TestEndpointsAreWired/new
FAIL
FAIL github.com/open-telemetry/opentelemetry-collector-contrib/extension/jaegerremotesampling/internal 10.753s
FAIL
The strategyType field in the api_v2 is not rendered because of the omitempty tag in the struct. What's the right way to address this in the extension?
See the PR here: #18400
Collector version
not-released-yet
Environment information
Environment
OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")
OpenTelemetry Collector configuration
No response
Log output
No response
Additional context
No response