[CI] Failing unit tests on main do not mark CI job as failed

[mx-psi]

Component(s)

No response

Describe the issue you're reporting

See e.g. https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/14620263662/job/41018250965 or https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/14632664161/job/41057710461. The tests failed (and were successfully reported by issuegenerator), but CI was not marked as failed.

[mx-psi]

CI on #39613 shows that this works correctly on PRs, it's only a problem on main

[ArthurSens]

That's weird, I was expecting that this part would fail the workflow:

opentelemetry-collector-contrib/.github/workflows/build-and-test.yml

Lines 316 to 320 in 1ff442c

	- name: Fail workflow if tests fails
	if: steps.tests-with-junit.outcome == 'failure' || steps.tests.outcome == 'failure'
	run: |
	echo "Tests failed. Failing workflow."
	exit 1

as we can see this is being skipped for some reason:

Following Github Action docs, I'm failing to understand why it is skipped 😭

[songy23]

Chatted offline, this is risky for normal PRs since they may not be up-to-date with mainline, but for release PRs it's probably fine. Because the CIs in PRs are working fine (fail when tests fail) and there is a merge freeze in place to make sure release PR is up-to-date.

Remove the release blocker label