[exporter/awsxray] Add logic for stripping the AWS.SDK prefix for Local Root spans #33001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we are fixing a couple small bugs missed in the previous review. First, we are adding a nil-guard when settting dependencySubsegment.Name, to avoid the (unlikely, but possible) scenario where local root dependency spans are created without awsRemoteService. Second, we are updating the common logic for setting segment.Name, which previously only looked at CLIENT/PRODUCER spans, but now needs to look at CONSUMER spans.
* Add logic for stripping the AWS.SDK prefix for Local Root spans - Previous change to strip the prefix in other cases open-telemetry@7c037ad * De-duplicate identical logic
jj22ee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Depends on PR (Shares the first 4 commits):
Cherry-picking from downstream:
amazon-contributing#127
Adding logic to strip AWS.SDK from local root dependency spans. This had been done previously for other spans, but there was a missed codepath related to local root naming. (Related previous change to strip the prefix in other cases 7c037ad)
Link to tracking Issue:
Testing:
Added a unit test
Documentation: