[processor/deltatocumulative]: drop bad samples #34979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichieSams
approved these changes
Sep 3, 2024
ArthurSens
reviewed
Sep 3, 2024
processor/deltatocumulativeprocessor/internal/data/datatest/compare/compare.go
Show resolved
Hide resolved
ArthurSens
approved these changes
Sep 5, 2024
jpkrohling
approved these changes
Sep 5, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
**Description:** While writing a test that exercises the public api, I noticed we record bad samples as metrics, but do not actually drop them. This is another result of the highly layered architecture that makes such things hard to understand. I'm working on removing that. **Link to tracking Issue:** **Testing:** public api tests were added **Documentation:** not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
While writing a test that exercises the public api, I noticed we record bad samples as metrics, but do not actually drop them.
This is another result of the highly layered architecture that makes such things hard to understand. I'm working on removing that.
Link to tracking Issue:
Testing: public api tests were added
Documentation: not needed