-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[pkg/translator/azure] Map application-defined properties #35402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/translator/azure] Map application-defined properties #35402
Conversation
Hi @joegoldman2, |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@cparkins please review |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Looks like this could use some unit tests. @joegoldman2 do you think you can add unit tests for the opentelemetry-collector-contrib/pkg/translator/azure/resourcelogs_to_logs_test.go Line 384 in 499df64
|
I agree a test would be nice. The change itself seems small enough it is ok to approve. |
Description:
#33583 introduced support for traces in Azure Event Hub receiver. However, application-defined properties have not been mapped. This PR fixes this and adds the mapping for properties.
Link to tracking Issue:
Testing:
Documentation:
cc @deepan10