Skip to content

[pkg/translator/azure] Map application-defined properties #35402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 20, 2025

Conversation

joegoldman2
Copy link
Contributor

Description:

#33583 introduced support for traces in Azure Event Hub receiver. However, application-defined properties have not been mapped. This PR fixes this and adds the mapping for properties.

Link to tracking Issue:

Testing:

Documentation:

cc @deepan10

@deepan10
Copy link
Contributor

deepan10 commented Oct 9, 2024

Hi @joegoldman2,
Thanks for the PR. I tested the implementation the application-defined properties are added into trace signal 👍

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 24, 2024
@github-actions github-actions bot removed the Stale label Oct 25, 2024
Copy link
Contributor

github-actions bot commented Nov 9, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 9, 2024
@github-actions github-actions bot removed the Stale label Nov 10, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 2, 2024
@github-actions github-actions bot removed the Stale label Dec 3, 2024
@dmitryax
Copy link
Member

dmitryax commented Dec 3, 2024

@cparkins please review

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 28, 2024
@github-actions github-actions bot removed the Stale label Jan 8, 2025
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 23, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 7, 2025
@andrzej-stencel
Copy link
Member

Looks like this could use some unit tests. @joegoldman2 do you think you can add unit tests for the UnmarshalTraces method, similar to the UnmarshalLogs tests?

@atoulme
Copy link
Contributor

atoulme commented Feb 20, 2025

I agree a test would be nice. The change itself seems small enough it is ok to approve.

@MovieStoreGuy MovieStoreGuy merged commit 6173862 into open-telemetry:main Feb 20, 2025
173 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants