-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[connector/routing] Add ability to route log records based on OTTL log context #35939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
djaglowski
merged 1 commit into
open-telemetry:main
from
djaglowski:routing-connector-by-record
Oct 25, 2024
Merged
[connector/routing] Add ability to route log records based on OTTL log context #35939
djaglowski
merged 1 commit into
open-telemetry:main
from
djaglowski:routing-connector-by-record
Oct 25, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec75457
to
5894833
Compare
5894833
to
5659ade
Compare
mwear
reviewed
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of non-blocking questions.
djaglowski
commented
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @mwear
mwear
approved these changes
Oct 25, 2024
jpbarto
pushed a commit
to jpbarto/opentelemetry-collector-contrib
that referenced
this pull request
Oct 29, 2024
…g context (open-telemetry#35939) This PR resolves open-telemetry#35948 by adding a `context` field to routing table items. The default value of `context` is `resource`, so that existing users will not see a difference. `log` context may also be used. Each routing table item may have a difference context. `match_once` must be `true` in order to use `log` context.
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…g context (open-telemetry#35939) This PR resolves open-telemetry#35948 by adding a `context` field to routing table items. The default value of `context` is `resource`, so that existing users will not see a difference. `log` context may also be used. Each routing table item may have a difference context. `match_once` must be `true` in order to use `log` context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #35948 by adding a
context
field to routing table items. The default value ofcontext
isresource
, so that existing users will not see a difference.log
context may also be used. Each routing table item may have a difference context.match_once
must betrue
in order to uselog
context.