[extension/oauth2clientauth] Add Token expiry buffer for oauth2clientauthextension #37334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
hi, I noticed that this PR has been marked as stale. Is there anyone available to review it? Please let me know if I can provide any additional information or make any improvements to help move it forward. Thanks! |
jpkrohling
approved these changes
Feb 8, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an expiry_buffer config to the oauth2client extension, allowing token refresh before expiration. The default buffer is set to 5 m, preventing authentication failures due to token expiration.
Link to tracking issue
Fixes #35148
Testing
passes tests.
Documentation
The README has been updated to include the expiry_buffer config option, with instructions on how to use it and its default value.