[chore] Extract zookeeper scraper as standalone module #37388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/otelcontribcol
bogdandrutu
force-pushed
the
extract-zookeeper-scraper
branch
8 times, most recently
from
4797d1d to
714df3a
Compare
bogdandrutu
force-pushed
the
extract-zookeeper-scraper
branch
from
714df3a to
9849c4a
Compare
djaglowski
approved these changes
Jan 22, 2025
bogdandrutu
force-pushed
the
extract-zookeeper-scraper
branch
2 times, most recently
from
9ad89ed to
8538310
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
extract-zookeeper-scraper
branch
from
8538310 to
fdcbf88
Compare
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Feb 8, 2025
…y#37388) Part of open-telemetry/opentelemetry-collector#11238 In this PR, only check that the new scraper interface for component and factory can be used for this use-case. Already proven for hostmetrics so no need for more than this. Items TODO next: * Add support in the integration tests to run directly the scraper. This will also make test more deterministic. * In core will add support for "scraperreceiver" and deprecate zookeeperreceiver when that is available. Signed-off-by: Bogdan Drutu <[email protected]>
zeck-ops
pushed a commit
to zeck-ops/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…y#37388) Part of open-telemetry/opentelemetry-collector#11238 In this PR, only check that the new scraper interface for component and factory can be used for this use-case. Already proven for hostmetrics so no need for more than this. Items TODO next: * Add support in the integration tests to run directly the scraper. This will also make test more deterministic. * In core will add support for "scraperreceiver" and deprecate zookeeperreceiver when that is available. Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of open-telemetry/opentelemetry-collector#11238
In this PR, only check that the new scraper interface for component and factory can be used for this use-case. Already proven for hostmetrics so no need for more than this.
Items TODO next: