-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[spanmetricsconnector] Add cardinality limit for the generated metrics #39084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Frapschen @portertech can you take a look to this PR? Thank you :D |
Frapschen
reviewed
Apr 11, 2025
iblancasa
commented
Apr 11, 2025
Signed-off-by: Israel Blancas <[email protected]>
…tor-contrib into 38990
@Frapschen @portertech can you review this? Thanks! |
Frapschen
approved these changes
Apr 23, 2025
@open-telemetry/collector-contrib-approvers I got the approval from the code owner. Can you take a look? |
atoulme
approved these changes
Apr 24, 2025
songy23
pushed a commit
that referenced
this pull request
Apr 24, 2025
I would like to become a code owner of spanmetrics connector. I have been using it in my current and previous companies. Also, I contributed some times to this component: #39084 #38945 #38001 #34485 Signed-off-by: Israel Blancas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38990