Add user actions support #39141
Merged
Add user actions support #39141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mar4uk
force-pushed
the
add-user-actions-support
branch
from
7f78431 to
71ea6fe
Compare
dehaansa
approved these changes
Apr 3, 2025
There was a problem hiding this comment.
LGTM, appreciate the added consistency on the constants.
The one thing I initially questioned was if an empty action was possible, but I see in the SDK that the json annotations for action include omitempty and this matches with the lack of output changes in existing tests.
Will mark ready for merge once CI is satisfied.
dehaansa
added
the
ready to merge
rlankfo
approved these changes
Apr 3, 2025
dmathieu
pushed a commit
to dmathieu/opentelemetry-collector-contrib
that referenced
this pull request
Apr 8, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adding support for user actions feature faro web SDK recently introduced grafana/faro-web-sdk#1033 (alpha version). Plus small fixes like: - add more tests - use constants where they should be used <!--Describe what testing was performed and which tests were added.--> #### Testing Added unit tests --------- Co-authored-by: Sam DeHaan <[email protected]>
LucianoGiannotti
pushed a commit
to LucianoGiannotti/opentelemetry-collector-contrib
that referenced
this pull request
Apr 9, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adding support for user actions feature faro web SDK recently introduced grafana/faro-web-sdk#1033 (alpha version). Plus small fixes like: - add more tests - use constants where they should be used <!--Describe what testing was performed and which tests were added.--> #### Testing Added unit tests --------- Co-authored-by: Sam DeHaan <[email protected]>
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adding support for user actions feature faro web SDK recently introduced grafana/faro-web-sdk#1033 (alpha version). Plus small fixes like: - add more tests - use constants where they should be used <!--Describe what testing was performed and which tests were added.--> #### Testing Added unit tests --------- Co-authored-by: Sam DeHaan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for user actions feature faro web SDK recently introduced grafana/faro-web-sdk#1033 (alpha version).
Plus small fixes like:
Testing
Added unit tests