[processor/resourcedetection] update to aws-sdk-go-v2 #39368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Shen <[email protected]>
github-actions
bot
added
the
processor/resourcedetection
@bogdandrutu Thanks for the review! I'm a relatively new contributor, so I'm just making sure here. I've made a couple aws-sdk-go-v2 migration PRs recently and was previously told that there's no need for a changelog since there isn't a user/API change (#39097 (comment)). Would you like me to write a changelog indicating a user-facing change? |
atoulme
approved these changes
Apr 14, 2025
akshays-19
pushed a commit
to akshays-19/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…#39368) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description aws-sdk-go is being [deprecated on July 31, 2025](https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/). This PR updates `processor/resourcedetection` to aws-sdk-go-v2. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#37730 <!--Describe what testing was performed and which tests were added.--> #### Testing I converted the existing unit tests to aws-sdk-go-v2 as well, keeping the original intent of the tests. Signed-off-by: Michael Shen <[email protected]>
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…#39368) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description aws-sdk-go is being [deprecated on July 31, 2025](https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/). This PR updates `processor/resourcedetection` to aws-sdk-go-v2. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#37730 <!--Describe what testing was performed and which tests were added.--> #### Testing I converted the existing unit tests to aws-sdk-go-v2 as well, keeping the original intent of the tests. Signed-off-by: Michael Shen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
aws-sdk-go is being deprecated on July 31, 2025. This PR updates
processor/resourcedetectionto aws-sdk-go-v2.Link to tracking issue
Fixes #37730
Testing
I converted the existing unit tests to aws-sdk-go-v2 as well, keeping the original intent of the tests.