Interface name added for ip and mac addr #39421
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
github-actions
bot
added
processor/resourcedetection
atoulme
reviewed
Apr 17, 2025
| hostIPAttribute = append(hostIPAttribute, ip.String()) | ||
| } | ||
| for _, result := range hostIPs { | ||
| attr := fmt.Sprintf("Interface: %s, IP: %s", result.InterfaceName, result.IP.String()) |
There was a problem hiding this comment.
I don't think that will land as is, as discussed in #39419
There was a problem hiding this comment.
Yeah i will create new pull request with updated changes . I am closing this one
This was referenced Apr 22, 2025
This was referenced May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds interface name added for ip and mac addr
Link to tracking Issue: #39419
Testing: No additional test cases were added