Skip to content

[processor/resourcedetection] add host.interface resource attribute to system detector #39472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

naman-jain-15
Copy link
Contributor

Description: This PR adds interface name

Link to tracking Issue: #39419

Testing: Additional test cases were added

@naman-jain-15
Copy link
Contributor Author

Hi , i have fixed the workflow issues

@naman-jain-15
Copy link
Contributor Author

Hi @ArthurSens @dashpole @Aneurysm9 Can we merge this or any issues ?

Copy link
Contributor

github-actions bot commented May 8, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 8, 2025
@ArthurSens
Copy link
Member

Hey @naman-jain-15, sorry for taking this long to answer you. I'm not a codeowner of this component, and not familiar with what it does at all.

David and Anthony are both inactive at the moment, so that's probably why you're not getting any answers here.

@open-telemetry/collector-contrib-maintainers, any idea on what to do here?

@naman-jain-15
Copy link
Contributor Author

Any updates ?? ..
@ArthurSens @dashpole @Aneurysm9 @odubajDT

Copy link
Member

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, suggested a couple tiny name updates.

@naman-jain-15
Copy link
Contributor Author

@andrzej-stencel Hi i have updated changes . Thanks !

@naman-jain-15
Copy link
Contributor Author

@andrzej-stencel Hi are there any issues ? . I have updated the linting issues

@andrzej-stencel andrzej-stencel changed the title Interface Names Added for resource Attribute #39421 [processor/resourcedetection] add host.interface resource attribute to system detector Jun 6, 2025
Copy link
Member

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@andrzej-stencel andrzej-stencel merged commit dab3488 into open-telemetry:main Jun 9, 2025
177 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 9, 2025
rockdaboot pushed a commit to rockdaboot/opentelemetry-collector-contrib that referenced this pull request Jun 10, 2025
… to `system` detector (open-telemetry#39472)

Description: This PR adds interface name 

Link to tracking Issue:
open-telemetry#39419

Testing: Additional test cases were added

---------

Co-authored-by: Andrzej Stencel <[email protected]>
dd-jasminesun pushed a commit to DataDog/opentelemetry-collector-contrib that referenced this pull request Jun 23, 2025
… to `system` detector (open-telemetry#39472)

Description: This PR adds interface name 

Link to tracking Issue:
open-telemetry#39419

Testing: Additional test cases were added

---------

Co-authored-by: Andrzej Stencel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants