-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[processor/resourcedetection] add host.interface
resource attribute to system
detector
#39472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/resourcedetection] add host.interface
resource attribute to system
detector
#39472
Conversation
Hi , i have fixed the workflow issues |
Hi @ArthurSens @dashpole @Aneurysm9 Can we merge this or any issues ? |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Hey @naman-jain-15, sorry for taking this long to answer you. I'm not a codeowner of this component, and not familiar with what it does at all. David and Anthony are both inactive at the moment, so that's probably why you're not getting any answers here. @open-telemetry/collector-contrib-maintainers, any idea on what to do here? |
Any updates ?? .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall, suggested a couple tiny name updates.
processor/resourcedetectionprocessor/internal/system/metadata.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrzej Stencel <[email protected]>
…yaml Co-authored-by: Andrzej Stencel <[email protected]>
Co-authored-by: Andrzej Stencel <[email protected]>
@andrzej-stencel Hi i have updated changes . Thanks ! |
@andrzej-stencel Hi are there any issues ? . I have updated the linting issues |
host.interface
resource attribute to system
detector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
… to `system` detector (open-telemetry#39472) Description: This PR adds interface name Link to tracking Issue: open-telemetry#39419 Testing: Additional test cases were added --------- Co-authored-by: Andrzej Stencel <[email protected]>
… to `system` detector (open-telemetry#39472) Description: This PR adds interface name Link to tracking Issue: open-telemetry#39419 Testing: Additional test cases were added --------- Co-authored-by: Andrzej Stencel <[email protected]>
Description: This PR adds interface name
Link to tracking Issue: #39419
Testing: Additional test cases were added