[processor/tailsampling] Deprecate invert sample decisions #39833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
atoulme
approved these changes
May 9, 2025
|
Written by codeowner, tests pass, changelog looks good -> merging. |
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
…metry#39833) #### Description Users can now use the newly added [Drop policy type](open-telemetry#39668) to explicitly drop (not sample) specific traces regardless of other policy decisions. This pull-request deprecates the invert sample decisions. This pull-request introduces a feature gate/flag, `processor.tailsamplingprocessor.disableinvertdecisions`, to disable the invert sampling decisions. The gate/flag influences the underlying policy evaluation for simplicity. With the gate/flag enabled, the string, numeric, and boolean filter policies still support `invert_match`, which continues to flip the decision for the individual policy (only `Sampled` and `NotSampled`). Letting `invert_match` be simple. #### Related Issues - open-telemetry#36673 - open-telemetry#33656 - open-telemetry#36795 - open-telemetry#34296 - open-telemetry#34085 - open-telemetry#29637 - open-telemetry#27049 - Probably more 😅 --------- Signed-off-by: Sean Porter <[email protected]>
dd-jasminesun
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Jun 23, 2025
…metry#39833) #### Description Users can now use the newly added [Drop policy type](open-telemetry#39668) to explicitly drop (not sample) specific traces regardless of other policy decisions. This pull-request deprecates the invert sample decisions. This pull-request introduces a feature gate/flag, `processor.tailsamplingprocessor.disableinvertdecisions`, to disable the invert sampling decisions. The gate/flag influences the underlying policy evaluation for simplicity. With the gate/flag enabled, the string, numeric, and boolean filter policies still support `invert_match`, which continues to flip the decision for the individual policy (only `Sampled` and `NotSampled`). Letting `invert_match` be simple. #### Related Issues - open-telemetry#36673 - open-telemetry#33656 - open-telemetry#36795 - open-telemetry#34296 - open-telemetry#34085 - open-telemetry#29637 - open-telemetry#27049 - Probably more 😅 --------- Signed-off-by: Sean Porter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users can now use the newly added Drop policy type to explicitly drop (not sample) specific traces regardless of other policy decisions. This pull-request deprecates the invert sample decisions.
This pull-request introduces a feature gate/flag,
processor.tailsamplingprocessor.disableinvertdecisions, to disable the invert sampling decisions. The gate/flag influences the underlying policy evaluation for simplicity. With the gate/flag enabled, the string, numeric, and boolean filter policies still supportinvert_match, which continues to flip the decision for the individual policy (onlySampledandNotSampled). Lettinginvert_matchbe simple.Related Issues