-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[signalfxexporter] Fix invalid and missing host metadata #40218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[signalfxexporter] Fix invalid and missing host metadata #40218
Conversation
e4f0d8e
to
c703fb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
From failing check:
|
@crobert-1 |
c703fb2
to
2121719
Compare
Please rebase to fix conflicts. |
Usually if |
…lector is deployed in a containerized environment and the host root filesystem is mounted to non-standard location. Signed-off-by: Dani Louca <[email protected]>
2121719
to
ade3977
Compare
…try#40218) #### Description Fix invalid and missing host metadata when the collector is deployed in a containerized environment and the host root filesystem is mounted to non-standard location. This PR introduces the `root_path` config option which is used to create gopsutil context using https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/internal/gopsutilenv Ideally this should be merged after open-telemetry#40213 To make sure gopsutilenv detects inconsistency if the root_path value between the hostmetrics receiver and sfx exporter are different #### Testing Unit tests and manual deployment #### Documentation README updated Signed-off-by: Dani Louca <[email protected]>
Description
Fix invalid and missing host metadata when the collector is deployed in a containerized environment and the host root filesystem is mounted to non-standard location.
This PR introduces the
root_path
config option which is used to create gopsutil context using https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/internal/gopsutilenvIdeally this should be merged after #40213
To make sure gopsutilenv detects inconsistency if the root_path value between the hostmetrics receiver and sfx exporter are different
Testing
Unit tests and manual deployment
Documentation
README updated