Skip to content

[receiver/netflow] Add common EtherTypes #40219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

spacekitteh
Copy link
Contributor

Adds some common EtherTypes to the netflow parser.

@spacekitteh spacekitteh requested review from evan-bradley and a team as code owners May 22, 2025 05:23
Copy link

linux-foundation-easycla bot commented May 22, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: spacekitteh / name: Sophie Taylor (c4364cc)

@evan-bradley
Copy link
Contributor

Thanks @spacekitteh. Could you add a changelog? You can generate one by running make chlog-new from the root of the repo.

@spacekitteh
Copy link
Contributor Author

Done!

@spacekitteh spacekitteh force-pushed the patch-1 branch 2 times, most recently from 9ec8667 to 924d526 Compare May 23, 2025 00:58
Adds some common EtherTypes to the parser.
@evan-bradley
Copy link
Contributor

This makes sense to me, but I don't have the full context necessary to give a meaningful approval. @dlopes7 could you take a look?

Copy link
Contributor

@dlopes7 dlopes7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@evan-bradley evan-bradley merged commit 6c2c4a7 into open-telemetry:main May 23, 2025
175 checks passed
@github-actions github-actions bot added this to the next release milestone May 23, 2025
dragonlord93 pushed a commit to dragonlord93/opentelemetry-collector-contrib that referenced this pull request May 23, 2025
dd-jasminesun pushed a commit to DataDog/opentelemetry-collector-contrib that referenced this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants