[receiver/sqlserver] add new attribute to de-duplicate page.life_expectancy #40359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
receiver/sqlserver
Run Windows
crobert-1
reviewed
May 29, 2025
…tor-contrib into fix-duplicate-data
|
updated, please take another look. thanks! @crobert-1 |
crobert-1
approved these changes
May 30, 2025
|
CI failure: |
|
Moving to draft while you work on the CI, please mark ready for review once addressed. |
the ci pass now |
atoulme
approved these changes
Jun 2, 2025
dd-jasminesun
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Jun 23, 2025
…ctancy (open-telemetry#40359) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description When exporting data to elasticsearch, we got error say data are duplicated. And turns out the perf counter query could return two rows for page life expectancy, they could have identicial value but with different `object` name. Hence added one attribute to deduplicate the data. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When exporting data to elasticsearch, we got error say data are duplicated. And turns out the perf counter query could return two rows for page life expectancy, they could have identicial value but with different
objectname. Hence added one attribute to deduplicate the data.Link to tracking issue
Fixes
Testing
Documentation