Skip to content

[receiver/sqlserver] Rename db.server.name to db.system.name #40361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .chloggen/sqlserver-fix-db-system-name.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note here that this is only relevant for top query (or logs), or just make it clear?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: sqlserverreceiver

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Fix incorrect attribute name for database system name in the top query event collection.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [40361]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: Rename `db.server.name` to `db.system.name` in SQL Server receiver to align with semantic conventions.

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [user]
2 changes: 1 addition & 1 deletion receiver/sqlserverreceiver/documentation.md
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ top query
| sqlserver.total_grant_kb | The total amount of reserved memory grant in KB this plan received since it was compiled, reported in delta value. | Any Int |
| server.address | The network address of the server hosting the database. | Any Str |
| server.port | The port number on which the server is listening. | Any Int |
| db.server.name | The name of the server hosting the database. | Any Str |
| db.system.name | The database management system (DBMS) product as identified by the client instrumentation. | Any Str |

## Resource Attributes

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions receiver/sqlserverreceiver/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ attributes:
server.port:
description: The port number on which the server is listening.
type: int
db.server.name:
description: The name of the server hosting the database.
db.system.name:
description: The database management system (DBMS) product as identified by the client instrumentation.
type: string

events:
Expand All @@ -149,7 +149,7 @@ events:
- sqlserver.total_grant_kb
- server.address
- server.port
- db.server.name
- db.system.name

metrics:
sqlserver.user.connection.count:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ resourceLogs:
- key: server.port
value:
intValue: "1433"
- key: db.server.name
- key: db.system.name
value:
stringValue: microsoft.sql_server
body: {}
Expand Down
Loading