[pkg/datadog] add hostname_detection_timeout and set default #40377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ankitpatel96,
dineshg13,
IbraheemA,
jade-guiton-dd,
liustanley and
mackjmr
songy23
approved these changes
May 29, 2025
mx-psi
reviewed
May 30, 2025
jackgopack4
force-pushed
the
jackgopack4/OTEL-2613-add-sourceprovider-timeout
branch
from
5c2fcf5 to
de13287
Compare
songy23
approved these changes
May 30, 2025
jackgopack4
changed the title
mx-psi
approved these changes
Jun 2, 2025
dd-jasminesun
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Jun 23, 2025
…lemetry#40377) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds `hostname_detection_timeout` config option and sets a reasonable default (25 seconds) <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#40373 <!--Describe what testing was performed and which tests were added.--> #### Testing manually run `make kind-build` and `make kind-install-daemonset` and verify collector does not crash after 30 seconds <!--Describe the documentation added.--> #### Documentation .chloggen and definition in datadogexporter examples folder <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
hostname_detection_timeoutconfig option and sets a reasonable default (25 seconds)Link to tracking issue
Fixes #40373
Testing
manually run
make kind-buildandmake kind-install-daemonsetand verify collector does not crash after 30 secondsDocumentation
.chloggen and definition in datadogexporter examples folder