-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add system.paging.faults
metrics on Windows
#40468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add system.paging.faults
metrics on Windows
#40468
Conversation
CI has failures in two scrappers of the
|
receiver/hostmetricsreceiver/internal/scraper/pagingscraper/paging_scraper_windows.go
Outdated
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/loadscraper/load_scraper_windows.go
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/pagingscraper/paging_scraper_windows_test.go
Outdated
Show resolved
Hide resolved
@pjanotti PTAL at the failing tests |
@dmitryax ops, I guess a ran the local tests on the wrong terminal 🤦🏼♂️ ... anyway, the only way to get the correct number of failures is either to have the page faults scraping on the same scope as the original |
#### Description Added the `system.paging.faults` metrics on Windows. #### Testing Besides updated tests the change was validated with a local run of the collector and the new metric. #### Documentation N/A since this metric was not documented as not being generated on Windows.
Description
Added the
system.paging.faults
metrics on Windows.Testing
Besides updated tests the change was validated with a local run of the collector and the new metric.
Documentation
N/A since this metric was not documented as not being generated on Windows.