[receiver/simpleprometheus] Pass labels configuration to Prometheus properly #40723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
commented
Jun 13, 2025
| @@ -112,7 +112,6 @@ func getPrometheusConfig(cfg *Config) (*prometheusreceiver.Config, error) { | |||
| for k, v := range cfg.Labels { | |||
| labels[model.LabelName(k)] = model.LabelValue(v) | |||
| } | |||
| labels[model.AddressLabel] = model.LabelValue(cfg.Endpoint) | |||
There was a problem hiding this comment.
This label is added to Targets as it was before, we're just directly setting it now.
jvoravong
approved these changes
Jun 16, 2025
atoulme
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides fix as described in the issue. The original issue was the the receiver was not properly configuring the Prometheus receiver, which this is a wrapper for. This change is to simply pass the labels under the
LabelsPrometheus receiver option, rather than underTarget.Link to tracking issue
Fixes #40722
Testing
Manually tested on CLI. There aren't good tests for this component, shown by this bug not being caught earlier. If anyone has any ideas for good ways to add tests here, I'd be happy to add them.