fix: unexport CodecovConfig struct #40790
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @edmocosta, @songy23, and @mwear 👋 Thanks for your earlier feedback 🙏 I’ve corrected the PR by updating only the original Please let me know if anything else needs to be improved — happy to make changes! Thanks again for your time and review! |
songy23
reviewed
Jun 18, 2025
| @@ -110,7 +110,7 @@ type ComponentManagement struct { | |||
| IndividualComponents []Component `json:"individual_components"` | |||
| } | |||
|
|
|||
| type CodecovConfig struct { | |||
| type codecovConfig struct { | |||
There was a problem hiding this comment.
You'll want to update the reference of it too
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Please address comment and failing CI and mark ready for review again |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR unexports the
CodecovConfigstruct fromcmd/codecovgen/main.goby changing its name fromCodecovConfigtocodecovConfig.This change aligns with Go's convention of using unexported (lowercase) struct names when they are not used outside the local package. This also matches the intention described in issue #40641.
Link to tracking issue
Fixes #40641
Testing
No functional logic has been changed, so existing tests (if any) should continue to pass.
Documentation
Not applicable — this is a small internal visibility change with no impact on external documentation.