[exporter/elasticsearchexporter] Add function to encode spans in ECS mapping mode #40807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girodav
changed the title
girodav
changed the title
|
/cc @carsonip @lahsivjar @JaredTan95 For some reason I cannot assign @carsonip and @lahsivjar as reviewers 🤔 |
carsonip
previously requested changes
Jun 20, 2025
.chloggen/add-function-to-encode-spans-in-ecs-mapping-mode.yaml
Outdated
Show resolved
Hide resolved
ChrsMark
approved these changes
Jun 27, 2025
ChrsMark
added
the
ready to merge
ChrsMark
dismissed
carsonip’s stale review
@carsonip is out these days, dismissing his review to unblock this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
elasticsearchexportermarks traces as supported when using ECS as the mapping mode. However, no actual SemConv to ECS mapping is implemented for traces.Instead, the exporter falls back to the generic
nonOtelEncoder, which doesn't perform any meaningful mapping. This breaks consumers that expect ECS-compliant data (e.g., Elastic APM).This PR adds a new
encodeSpanfunction forecsModeEncoderthat follows similar logic toencodeLog.