-
Notifications
You must be signed in to change notification settings - Fork 2.9k
kafkareceiver: Improve internal telemetry #40846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kafkareceiver: Improve internal telemetry #40846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good. There are a couple of breaking changes here, we'll need to be clear about that in the changelog.
telemetry: | ||
metrics: | ||
kafka_receiver_messages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a breaking change. For the receiver we should either add a new "records" metric and keep the "messages" one but deprecate it; or alternatively update the exporter to use "messages" instead of "records". Sorry, I forgot we had this one.
I'd probably update the exporter metric for now, and we could deprecate/rename later. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with either options, I agree that using records
should be more "correct" way to call the metric. But if the preferred way is to introduce less breaking changes I will update the exporter PR to use messages
for the metric name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated both the receiver and the exporter PRs to use consistent naming for messages
to not cause any more breaking changes for now. Please take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you!
Description
This PR adds the following internal telemetry metrics to improve the receiver telemetry to make it easier to operate.
Click to expand
Link to tracking issue
Fixes
#40816
Testing
Unit tests are updated and tested manually.
Documentation
Documentation is autogenerated with mdatagen.